Keep medication edit controls in the existing Edit screen.
Photo Add/Change and duplicate Archive/Reactivate detail shortcuts are removed.
Toolbar Edit retains photo Add/Replace/Remove and Archive/Reactivate; detail has no photo editing shortcuts.
The circle, tap-to-view full stored image, storage and care behavior are unchanged.
Ready to push
Four source review perspectives clear. Five targeted native UI cases passed, including Edit-based photo controls and full-size viewing. Strict lint and whitespace passed.
Photo Add/Change and Archive/Reactivate shortcuts are gone from detail. Use Edit for those controls, or tap an existing picture to view it larger.
The link opened the same editor as Edit.
This removes a duplicate entry point, not the editing controls.
MedicationDetailView removes both photo editing shortcuts and duplicate Archive/Reactivate controls. Those controls already exist in Edit. Toolbar Edit, photo viewing, care actions and the repeats exception remain unchanged.
Removing duplicate controls is sufficient. Existing photo journeys enter through Edit, verify shortcut absence with and without photos, and retain editor Add/Archive reachability checks.
The change alters only presentation of an editor entry point. No model, importer, snapshot, cache, ownership or mutation path changes.
Four affected synthetic photo UI journeys cover dark/light photo draft controls, Save/Cancel and profile isolation, plus full-image zoom/dismiss/reopen and unreadable fallback. The existing prescription journey verifies the repeats exception. No broad domain or UI suite was necessary.
The requested edit shortcuts are removed and retained paths pass targeted native checks. No install, merge or live-data acceptance claim.
Meddy/Meddy/Features/MedicationDetailView.swift
Why it matters. Photo and Archive/Reactivate editing use existing Edit.
What to look at. Detail header and Settings controls
Meddy/MeddyUITests/MeddyPhotoUITests.swift
Why it matters. Verify controls remain usable after the link removal.
What to look at. Shortcut absence and Edit Add/Archive reachability
Source: local run at 2026-10-09T14:30:54.792084+00:00 · snapshot f7f1e13b6e9d84652acac0f015e00c5b2aa92be3
Baseline: none
Execution: passed · JUnit: 2 files · Coverage: none · Baseline: absent
Coverage scope: as the project configures it
Totals: 5 passed · 0 failed · 0 skipped · 0 errored · 0 flaky
Derived by declaration name, from the diff (no baseline run).
No new or removed test declarations.
Files that import a changed file on the left, changed files in the centre, files a changed file imports on the right. Snapshot working-tree against base 263df6d8dd54993c86bf80c94fcb194016a21120.
5 files: 2 code · 3 docs. Click to expand.
diff --git a/Meddy/Meddy/Features/MedicationDetailView.swift b/Meddy/Meddy/Features/MedicationDetailView.swiftindex 030ffe9..0678eb7 100644--- a/Meddy/Meddy/Features/MedicationDetailView.swift+++ b/Meddy/Meddy/Features/MedicationDetailView.swift@@ -47,9 +47,6 @@ struct MedicationDetailView: View { Spacer() } }- Button(medication.recognitionPhotoData == nil ? "Add recognition photo" : "Change recognition photo") {- editing = true- } }.listRowBackground(Color.clear).listRowSeparator(.hidden) VStack(alignment: .leading, spacing: 16) { if medication.scheduleTypeRaw == "asNeeded" {@@ -142,9 +139,6 @@ struct MedicationDetailView: View { ).font(.caption) } }- Button(medication.isActive ? "Archive" : "Reactivate") {- perform { try service.setActive(medication, !medication.isActive) }- }.foregroundStyle(Color("MeddyDestructive")) } }.meddyScreen() .navigationTitle(medication.name)
diff --git a/Meddy/MeddyUITests/MeddyPhotoUITests.swift b/Meddy/MeddyUITests/MeddyPhotoUITests.swiftindex 9f33dec..653f67b 100644--- a/Meddy/MeddyUITests/MeddyPhotoUITests.swift+++ b/Meddy/MeddyUITests/MeddyPhotoUITests.swift@@ -9,6 +9,10 @@ final class MeddyPhotoUITests: XCTestCase { let app = openDetailPhoto() let thumbnail = app.descendants(matching: .any)["medicationRecognitionPhoto"].firstMatch XCTAssertEqual(thumbnail.frame.width, 220, accuracy: 1)+ XCTAssertFalse(app.buttons["Change recognition photo"].exists)+ XCTAssertFalse(app.buttons["Add recognition photo"].exists)+ XCTAssertFalse(app.buttons["Archive"].exists)+ XCTAssertFalse(app.buttons["Reactivate"].exists) thumbnail.tap() let fullPhoto = app.descendants(matching: .any)["medicationFullPhoto"].firstMatch XCTAssertTrue(fullPhoto.waitForExistence(timeout: 5))@@ -55,7 +59,11 @@ final class MeddyPhotoUITests: XCTestCase { XCTAssertTrue(app.buttons["dismissFullPhoto"].isHittable) capture("full-photo-unavailable", app: app) app.buttons["dismissFullPhoto"].tap()- XCTAssertTrue(app.buttons["Change recognition photo"].waitForExistence(timeout: 3))+ XCTAssertTrue(app.buttons["Edit"].waitForExistence(timeout: 3))+ XCTAssertFalse(app.buttons["Change recognition photo"].exists)+ XCTAssertFalse(app.buttons["Add recognition photo"].exists)+ XCTAssertFalse(app.buttons["Archive"].exists)+ XCTAssertFalse(app.buttons["Reactivate"].exists) XCTAssertFalse(app.alerts.firstMatch.exists) } @@ -117,7 +125,11 @@ final class MeddyPhotoUITests: XCTestCase { capture("detail-photo-" + appearance, app: app) XCTAssertEqual(photo.frame.width, 220, accuracy: 1) XCTAssertTrue(photo.isHittable)- app.buttons["Change recognition photo"].tap()+ XCTAssertFalse(app.buttons["Change recognition photo"].exists)+ XCTAssertFalse(app.buttons["Add recognition photo"].exists)+ XCTAssertFalse(app.buttons["Archive"].exists)+ XCTAssertFalse(app.buttons["Reactivate"].exists)+ app.buttons["Edit"].tap() reveal(app.buttons["Replace photo"], app: app) XCTAssertTrue(app.buttons["Replace photo"].waitForExistence(timeout: 5)) XCTAssertTrue(app.buttons["Remove photo"].exists)@@ -138,12 +150,27 @@ final class MeddyPhotoUITests: XCTestCase { XCTAssertEqual(photo.frame.width, 160, accuracy: 1) capture("dose-photo-" + appearance, app: app) app.buttons["Cancel"].tap()- app.buttons["Change recognition photo"].tap()+ XCTAssertFalse(app.buttons["Change recognition photo"].exists)+ XCTAssertFalse(app.buttons["Add recognition photo"].exists)+ XCTAssertFalse(app.buttons["Archive"].exists)+ XCTAssertFalse(app.buttons["Reactivate"].exists)+ app.buttons["Edit"].tap() reveal(app.buttons["Remove photo"], app: app) app.buttons["Remove photo"].tap() app.buttons["Save"].tap()- XCTAssertTrue(app.buttons["Add recognition photo"].waitForExistence(timeout: 3))+ XCTAssertTrue(app.buttons["Edit"].waitForExistence(timeout: 3))+ XCTAssertFalse(app.buttons["Change recognition photo"].exists)+ XCTAssertFalse(app.buttons["Add recognition photo"].exists)+ XCTAssertFalse(app.buttons["Archive"].exists)+ XCTAssertFalse(app.buttons["Reactivate"].exists) XCTAssertFalse(photo.exists)+ capture("detail-no-photo-" + appearance, app: app)+ app.buttons["Edit"].tap()+ reveal(app.buttons["Add photo"], app: app)+ XCTAssertTrue(app.buttons["Add photo"].exists)+ reveal(app.buttons["Archive medication"], app: app)+ XCTAssertTrue(app.buttons["Archive medication"].isHittable)+ app.buttons["Cancel"].tap() openMedicationLibrary(app: app) XCTAssertTrue(row.waitForExistence(timeout: 3)) XCTAssertNotEqual(row.value as? String, "Recognition photo attached")
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 96a2259..4249ccd 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -3,6 +3,7 @@ ## Unreleased ### Changed+- Keep medication photo Add/Change and Archive/Reactivate controls in Edit; remove their redundant detail shortcuts while retaining photo viewing, repeats-counter changes and care actions. - Show “Repeats left: x” in Share for appointment and its Markdown output only when the remaining count is positive; omit zero and unset counts without changing repeat accounting. - Present medication recognition images consistently as circles, using a display-only aspect-fill crop without changing stored photos or photo controls. - Recreate the Meddy redesign in native SwiftUI with dark/light lavender tokens, purpose cards, focused Today actions, searchable medication lists, routine progress, grouped editors and avatar-based profiles. Preserve existing care history, frozen sessions, explicit timer continuation and dose-limit semantics without a schema migration.
diff --git a/docs/meddy-design.md b/docs/meddy-design.mdindex a52cceb..d6fcca2 100644--- a/docs/meddy-design.md+++ b/docs/meddy-design.md@@ -1699,7 +1699,7 @@ Existing purpose relationships already support the design; no model migration is Focused simulator verification covers all nine designed screens in both appearances and primary recording/navigation interactions. See the implementation plan for gate status. This redesign changes no account, signing, entitlement or CloudKit configuration and requires no real-store reset. -Owner feedback on missing photos restores the existing §23 recognition surfaces within this visual direction. Medication library rows and Today due/later/PRN/taken cards show the current aspect-preserving thumbnail alongside the name. Medication detail presents its larger image near the heading, with an Add/Change recognition photo shortcut to the existing editor. The editor's Add/Replace/Remove draft controls follow the medication identity fields; detailed dose logging and ordered routine steps retain their recognition images. A medication without a photo keeps its name-based layout, without reserving an empty thumbnail. Existing nullable storage, bounded processing/cache, profile filtering, Save/Cancel behavior and iPhone-only scope remain unchanged.+Owner feedback on missing photos restores the existing §23 recognition surfaces within this visual direction. Medication library rows and Today due/later/PRN/taken cards show the current aspect-preserving thumbnail alongside the name. Medication detail presents its larger image near the heading, with photo Add/Replace/Remove controls available only through the navigation bar’s Edit button. Both Add and Change recognition photo shortcuts beneath the heading/image are removed; a medication without a photo reserves no empty preview. Duplicate Archive/Reactivate shortcuts are also removed from detail; the existing Edit controls remain. Detail retains repeats decrement/Undo as the explicit settings-mutation exception, full-size photo viewing, dose logging, reminders and historical care corrections. The editor's Add/Replace/Remove draft controls follow the medication identity fields; detailed dose logging and ordered routine steps retain their recognition images. A medication without a photo keeps its name-based layout, without reserving an empty thumbnail. Existing nullable storage, bounded processing/cache, profile filtering, Save/Cancel behavior and iPhone-only scope remain unchanged. ## 32. Approved prescription metadata (2026-10-08)
diff --git a/docs/meddy-implementation-plan.md b/docs/meddy-implementation-plan.mdindex cc8a9b1..3401429 100644--- a/docs/meddy-implementation-plan.md+++ b/docs/meddy-implementation-plan.md@@ -1,5 +1,9 @@ # Meddy — Implementation task plan +## Remove redundant detail edit shortcuts++PR #9 scope update: photo Add/Change and medication Archive/Reactivate belong in the existing Edit screen. Remove those detail shortcuts, preserve the inline full-size viewer when a photo exists and a compact name-based header when absent. The existing editor retains photo Add/Replace/Remove and Archive/Reactivate. Repeats decrement/Undo is the explicit settings-mutation exception; dose logging, reminders, Undo Taken and historical care corrections remain. No model, persistence, care policy or account/signing changes. The photo journeys now assert shortcut absence with/without a photo and reach retained Add/Archive controls through Edit; the existing prescription journey verifies the repeats exception. Earlier PR #9 verification at d0025a4 covered Change-link removal only and is superseded for this expanded delta. Verification at clean `f7f1e13`: the initial targeted invocation passed all four photo journeys and timed out the progressing prescription journey at its 120-second allowance. A prescription-only retry on identical source passed in 185.5 seconds with a bounded 240-second allowance. Five disjoint cases have passing evidence across those runs; the original mixed timeout receipt is retained, not described as an all-green five-case invocation. Photo coverage includes both appearances, compact no-photo layout, retained Edit Add/Archive reachability, Save/Cancel/profile behavior, viewing zoom/dismiss/reopen and unreadable fallback. The prescription journey covers the repeats decrement/Undo exception. Reactivate retention is source-reviewed rather than exercised by active fixtures. Strict lint passed 114 files with zero violations; whitespace and four source review perspectives passed. Screenshots reviewed. Known synthetic fixture background-publication warning retained. Owned jobs drained, assigned phone/Watch simulators restored to Shutdown, and heavy lane explicitly released. Update the same pending Transit ticket for app Meddy when tracking becomes available, without creating a duplicate. No install or merge.+ ## Appointment remaining repeats Show `Repeats left: x` on Share for appointment only when the remaining count is positive, with the same omission rule in the shared Markdown output. Zero and unset counts are omitted from these two appointment surfaces. Stored values, medication detail, decrement/Undo, profile filtering and other prescription metadata remain unchanged. No warning, signing/account change, migration, installation or automatic sharing is added. Affected export/prescription tests and the existing prescription UI journey cover positive/zero/unset output and unchanged repeat accounting.@@ -322,7 +326,7 @@ Behavior deliberately retained from the approved care design: captured profile/l Coverage of screens without mocks: shared grouped surfaces and colors apply to treatment/routine editors, profile management, photo/follow-up/limits fields and appointment sharing. Routine and treatment detail lead with a purpose card, preserve history and independent session controls; canonical history and review remain available from execution screens. Empty medication/Today states use a single explanatory hero. -Photo restoration after owner feedback: comparison with `70f79a8` found that the redesign removed medication-row and detailed-dose recognition images, moved the detail image into Settings, and moved the editor's retained photo controls to the bottom. `recognitionPhotoData`, the photo service/importer and draft transaction were retained; no personal store was inspected. The correction reuses `MedicationPhotoView` for library/Today thumbnails, a prominent detail image, detailed logging and the ordered routine's all-steps list. Add/Replace/Remove are reachable near the editor's identity fields; detail opens that same editor through Add/Change recognition photo. Routine selection and the current-step image were already retained. There is no new photo storage, permission, export or Watch transport.+Photo restoration after owner feedback: comparison with `70f79a8` found that the redesign removed medication-row and detailed-dose recognition images, moved the detail image into Settings, and moved the editor's retained photo controls to the bottom. `recognitionPhotoData`, the photo service/importer and draft transaction were retained; no personal store was inspected. The correction reuses `MedicationPhotoView` for library/Today thumbnails, a prominent detail image, detailed logging and the ordered routine's all-steps list. Add/Replace/Remove are reachable near the editor's identity fields; detail opens that same editor only through the navigation bar’s Edit button. Routine selection and the current-step image were already retained. There is no new photo storage, permission, export or Watch transport. Source review through four perspectives found no photo/data/profile blocker; a narrow PRN-tile layout concern was addressed by placing the thumbnail above the name header. Due and attention cards retain combined VoiceOver status/dose/instruction labels, with photo presence added separately. Strict SwiftLint passes all 111 Swift files with zero violations, and whitespace validation passes. Focused verification at `cc8bed7` passes **nine photo domain tests and both dark/light photo UI scenarios**, command exit 0 (`focused-verification`, 219.498 seconds). They cover attached/absent visibility, same-name profile separation, Replace picker cancellation, Remove/Cancel, saved removal and preservation of another medication's photo. The nine existing photo domain assertions cover bounded import/metadata, replacement, rollback, relaunch and stale drafts. The first `cf40672` attempt passed the nine domain tests but failed both UI journeys on navigation assumptions; native accessibility evidence showed a profile-scoped tab rebuilding after the first tap, and a redundant Back after re-tapping Medications had already returned to the library. The correction waits for the actual library search field and retains every photo/profile assertion.
Four photo cases passed in the initial mixed invocation; its prescription case timed out at 120 seconds. Only that method was rerun with a bounded 240-second allowance and passed on identical source. Five disjoint selected UI cases therefore have passing evidence at clean f7f1e13; no skipped or failed cases. Synthetic fixture startup retains the known background-publication runtime warning. Profile-change dismissal in the full-screen viewer remains source-reviewed, not directly exercised by this batch. Screenshots reviewed; no personal records used. Reactivate retention is source-reviewed; active fixtures exercise Archive.
The standing approval covers a Transit ticket for app Meddy. Transit tools are not exposed here; no repeated timeout, restart or configuration change was attempted.