Pre-push review: T-2193 capture page-title accessibility label

diff --git a/Asterism/AsterismShareExtension/CaptureView.swift b/Asterism/AsterismShareExtension/CaptureView.swiftindex abc2467..9b10763 100644--- a/Asterism/AsterismShareExtension/CaptureView.swift+++ b/Asterism/AsterismShareExtension/CaptureView.swift@@ -207,7 +207,7 @@ struct CaptureView: View {                 } else if let rawTitle {                     Text(rawTitle)                         .font(AsterismTypography.serifHeading)-                        .accessibilityLabel("Page title")+                        .accessibilityLabel("Page title: \(rawTitle)")                         .accessibilityIdentifier("capture.pageTitle")                 }             }

diff --git a/specs/bugfixes/capture-view-page-title-accessibility-label/report.md b/specs/bugfixes/capture-view-page-title-accessibility-label/report.mdnew file mode 100644index 0000000..4c51a4e--- /dev/null+++ b/specs/bugfixes/capture-view-page-title-accessibility-label/report.md@@ -0,0 +1,135 @@+# Bugfix Report: CaptureView Page-Title Accessibility Label Hides the Actual Title++**Date:** 2026-08-29+**Status:** Fixed++## Description of the Issue++`CaptureView.swift`'s raw-title row set `.accessibilityLabel("Page title")` on+the `Text(rawTitle)` view. `accessibilityLabel` replaces an element's+accessible content rather than annotating it, so VoiceOver announced the+literal string "Page title" and never read the actual title value the row was+displaying.++**Reproduction steps:**+1. Share a page whose title could not be parsed into a work/chapter (or any+   case where `metadataSection` falls through to the `rawTitle` branch — see+   Q1 in the surrounding doc comment).+2. Open the capture sheet with VoiceOver running.+3. Focus the title row.+4. Observe VoiceOver announces "Page title" — the title itself is never+   spoken.++**Impact:** Low severity, but a real accessibility regression for VoiceOver+users on every capture whose title falls into the raw-title display path —+they cannot hear what page they are about to save without turning to a+sighted assistant.++## Investigation Summary++Pre-existing defect, surfaced during the T-2190 review (which added the+`reshare.title` label on the equivalent row in the re-share flow).++- **Symptoms examined:** The single call site,+  `Asterism/AsterismShareExtension/CaptureView.swift:210`, inside+  `metadataSection(preparation:outcome:)`.+- **Code inspected:** The sibling informative labels in the same file —+  `projectedMetadataSection`'s article/work/chapter rows (each uses+  `"Label: \(value)"`, e.g. `"Chapter: \(chapter)"` at line 293) — and the+  equivalent row in `ReShareCaptureView.swift` (`"Entry title:+  \(state.title)"` on `reshare.title`, line 123).+- **Hypotheses tested:** None needed — the description and the sibling+  pattern make the root cause and fix unambiguous.++## Discovered Root Cause++**Defect type:** Accessibility label replaces content instead of describing+it.++**Why it occurred:** `.accessibilityLabel("Page title")` was written as a+static caption rather than an interpolated description of the row's value,+unlike every other informative row in the same view and its `ReShareCaptureView`+sibling.++**Contributing factors:** No test coverage exists for SwiftUI accessibility+label strings in the share-extension views (see Regression Test section), so+the mismatch between this one row and its siblings went unnoticed.++## Resolution for the Issue++**Changes made:**+- `Asterism/AsterismShareExtension/CaptureView.swift:210` — changed+  `.accessibilityLabel("Page title")` to+  `.accessibilityLabel("Page title: \(rawTitle)")`.++**Approach rationale:** Matches the established convention in this same file+(`"Chapter: \(chapter)"`, `"Article title: \(displayTitle)"`,+`"Work: \(workTitle)..."`) and in `ReShareCaptureView.swift`+(`"Entry title: \(state.title)"`), exactly as the ticket asked.++**Alternatives considered:**+- Removing the `accessibilityLabel` entirely and letting VoiceOver read the+  `Text` content directly — rejected because the existing+  `capture.pageTitle` accessibility identifier and the project's+  established row convention (an explicit `"Label: value"` label on every+  informative row) are both worth keeping consistent with the rest of the+  view.++## Regression Test++No automated regression test was added. `CaptureView.swift` lives in the+`AsterismShareExtension` target, which `make test-core` does not compile+(per `CLAUDE.md`), and this repository has no ViewInspector/SnapshotTesting+dependency or XCUITest harness capable of driving the share extension's UI+(`AccessibilityJourneyUITests.swift` only exercises the main app; there is no+share-extension launch support in `UITestLaunchSupport.swift`). The sibling+label this fix matches (`reshare.title` in `ReShareCaptureView.swift`,+added by T-2190) is likewise untested at the string level. Introducing that+test infrastructure is out of scope for a one-line accessibility-string fix.++Verification instead relied on:+- Reading the sibling label call sites to confirm the fixed string matches+  their established convention.+- `make test-quick`, which builds the full `Asterism Development` scheme+  (including the share extension target) on the simulator and runs the+  unit-test bundle, confirming the change compiles and introduces no+  regressions.+- `make test-core`, confirming the `AsterismCore`/`AsterismIntelligence`+  package tests are unaffected.++**Run command:** `make test-quick` (simulator, safe); `make test-core`++## Affected Files++| File | Change |+|------|--------|+| `Asterism/AsterismShareExtension/CaptureView.swift` | `.accessibilityLabel("Page title")` → `.accessibilityLabel("Page title: \(rawTitle)")` on the raw-title row |++## Verification++**Automated:**+- [ ] Regression test passes — none added, see rationale above+- [x] Full test suite passes (`make test-quick`, `make test-core`)+- [x] Linters/validators pass — no linter/formatter configured in this repo (per `CLAUDE.md`); a clean `make test-core` with no new compiler warnings is the pre-commit bar, and it passed++**Manual verification:**+- Confirmed the fixed string matches the `"Label: value"` convention used by+  every other informative accessibility label in `CaptureView.swift` and by+  `reshare.title` in `ReShareCaptureView.swift`.++## Prevention++**Recommendations to avoid similar bugs:**+- When adding an `.accessibilityLabel` to a row that echoes dynamic content,+  interpolate the value into the label rather than writing a static caption+  — a static caption silently discards the content VoiceOver would otherwise+  read.+- Consider adding ViewInspector (or similar) coverage for the share+  extension's SwiftUI views if these accessibility regressions recur; none+  exists today for either `CaptureView` or `ReShareCaptureView`.++## Related++- T-2193 (this ticket)+- T-2190 (added the `reshare.title` label this fix now matches, and whose+  review surfaced this pre-existing bug)